Skip to content

react-doctor: label the notification channel field controls (control-has-associated-label) #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stonexer wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

react-doctor: label the notification channel field controls (control-has-associated-label) #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/server/src/components/NotificationsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,18 @@ export function NotificationsModal({ open, onClose }: { open: boolean; onClose:
if (f.requires && !fields[f.requires]?.trim()) return null
const isSlackChannel = adding === 'slack' && f.key === 'channel'
const picked = isSlackChannel ? slackChannels?.find((c) => c.id === fields.channel) : undefined
// One id per field, shared by the two mutually exclusive control branches
// below (only ever one is rendered), so the visible label names the control.
const fieldId = `notif-field-${f.key}`
return (
<div key={f.key}>
<label className={labelCls}>{f.label}</label>
<label className={labelCls} htmlFor={fieldId}>
{f.label}
</label>
{isSlackChannel && !slackManual && slackChannels ? (
<>
<select
id={fieldId}
className={inputCls}
value={fields.channel ?? ''}
onChange={(e) => setFields((s) => ({ ...s, channel: e.target.value }))}
Expand All @@ -290,6 +296,7 @@ export function NotificationsModal({ open, onClose }: { open: boolean; onClose:
) : (
<>
<input
id={fieldId}
className={`${inputCls} font-mono`}
value={fields[f.key] ?? ''}
onChange={(e) => setFields((s) => ({ ...s, [f.key]: e.target.value }))}
Expand Down