SD-1460 - fix: don't drop track format on run nodes #1850
+107
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chittolinag
commented
Jan 27, 2026
| * @returns {Object|undefined} Properties element for trackFormat change or undefined. | ||
| */ | ||
| export const createTrackStyleMark = (marks) => { | ||
| export const decodeTrackFormatMark = (marks) => { |
Contributor
Author
There was a problem hiding this comment.
Renamed this - the current name seems counter-intuitive, it's not creating a mark, but instead decoding it back to OOXML.
Thoughts?
chittolinag
requested review from
VladaHarbour,
harbournick and
luccas-harbour
chittolinag
commented
Jan 27, 2026
packages/super-editor/src/core/super-converter/v3/handlers/w/r/r-translator.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v3/handlers/w/r/r-translator.js
Show resolved
Hide resolved
chittolinag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked formatting changes were being dropped after export.
The reason is that we were not re-generating the
rPrChangeelement before decoding the run node. We do encode them correctly, but we were just missing doing it in the opposite direction.