fix(super-converter): return transparent instead of blue for shapes #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout fill SD-1651: When a text box or shape has no explicit fill color specified in spPr and no style element, extractFillColor was returning the default blue (#5b9bd5) instead of null (transparent). Per ECMA-376 spec, shapes without fill specification should be transparent. This fix changes three return statements from returning blue to returning null when: - No style element exists - Style exists but no fillRef - fillRef exists but no schemeClr This fixes text boxes appearing with blue backgrounds when they should be transparent.
caio-pizzol
requested review from
artem-harbour and
harbournick
and removed request for
harbournick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.