Skip to content

fix: selection/caret issues #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
artem-harbour wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: selection/caret issues #1865

artem-harbour wants to merge 4 commits into from
+45 −2

Conversation

@artem-harbour
Copy link
Contributor

@artem-harbour artem-harbour commented Jan 28, 2026 •
edited
Loading

Linear: SD-1439.

This PR fixes several issues.

  • Do not render the caret initially when there is no editor focus.
  • Set editor focus before selection to set the caret correctly. This fixes the first editor click issue so that the caret appears at the click location rather than at the beginning of the document.
  • Update selection/caret on editor focus/blur. This fixes the issue with caret rendering when focus is not on the editor.

@artem-harbour artem-harbour self-assigned this Jan 28, 2026
@linear
Copy link

linear bot commented Jan 28, 2026

SD-1439 Bug: Typing Not Registered Until User Clicks into Editor

@artem-harbour artem-harbour marked this pull request as ready for review January 28, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harbournick harbournick Awaiting requested review from harbournick

At least 1 approving review is required to merge this pull request.

Assignees

@artem-harbour artem-harbour

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artem-harbour