Skip to content

Fix crash in DebounceAsyncSequence #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macdrevx merged 2 commits into from
Aug 4, 2025
Merged

Fix crash in DebounceAsyncSequence #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3905dd5
Fix crash in DebounceAsyncSequence
macdrevx Aug 4, 2025
721606c
Use NSEC_PER_SEC instead of 1_000_000_000 literal
macdrevx Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Sources/Asynchrone/Sequences/DebounceAsyncSequence.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ extension DebounceAsyncSequence {

public mutating func next() async rethrows -> Element? {
var lastResult: Result<Element?, Error>?
var lastEmission: Date = .init()


while true {
let resultTask = self.resultTask ?? Task<RaceResult, Never> { [base] in
var iterator = base
Expand All @@ -105,14 +104,12 @@ extension DebounceAsyncSequence {
}
}
self.resultTask = nil

lastEmission = Date()
let delay = UInt64(self.dueTime - Date().timeIntervalSince(lastEmission)) * 1_000_000_000
let sleep = Task<RaceResult, Never> {
try? await Task.sleep(nanoseconds: delay)

let sleep = Task<RaceResult, Never> { [dueTime] in
try? await Task.sleep(nanoseconds: UInt64(Swift.max(dueTime, 0)) * NSEC_PER_SEC)
return .sleep
}

let tasks = [resultTask, sleep]
let firstTask = await { () async -> Task<RaceResult, Never> in
let raceCoordinator = TaskRaceCoodinator<RaceResult, Never>()
Expand Down Expand Up @@ -140,7 +137,6 @@ extension DebounceAsyncSequence {
switch await firstTask.value {
case .winner(let result, let iterator):
lastResult = result
lastEmission = Date()
self.base = iterator

switch result {
Expand Down
Loading