Show MCP connection status in integrations#1135
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 0728c2b | Jun 27 2026, 03:29 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 0728c2b | Commit Preview URL Branch Preview URL |
Jun 27 2026, 03:30 PM |
|
Update after latest commit:
|
|
Claude finished @ishaanxgupta's task in 1m 23s —— View job Review Complete
All previously reported issues have been addressed:
Score: 9/10 — Good to ship. |
There was a problem hiding this comment.
Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.
Issues found:
- Character encoding bug: Three instances of
·instead of·(middle dot) at lines 1098, 1511, and 1528. This will display incorrectly in the UI.
Score: 8/10
The logic and structure look solid. The code correctly reuses the existing MCP metadata signals (sm_source: "mcp" or sm_kind: "mcp_oauth_exchange"), properly handles null/undefined cases, and integrates cleanly with the existing rail entry system. The activeMcpKey memo correctly finds the most recent key by comparing timestamps.
Fix the encoding issue and this is good to ship.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.
Issues found:
- The encoding bug at line 1098 (
McpConnectedPill) was fixed ✓ - Two instances of
·instead of·remain inMcpRailRowat lines 1511 and 1528
Score: 8/10
The logic and structure look solid. The code correctly reuses the existing MCP metadata signals, properly handles null/undefined cases, and integrates cleanly with the existing rail entry system. The activeMcpKey memo correctly finds the most recent key by comparing timestamps.
Fix the remaining two encoding issues and this is good to ship.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
MaheshtheDev
left a comment
There was a problem hiding this comment.
add mcp icon instead of black icon in active status
There was a problem hiding this comment.
Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.
Issues found: None — all previously reported encoding bugs have been fixed, and the MCP icon is now properly implemented with a gradient SVG.
Score: 9/10
The implementation is solid:
isMcpAuthMetadata()correctly identifies MCP keys viasm_sourceorsm_kindmetadataparseMcpAuthKeys()safely handles JSON parsing with try/catch and filters disabled keysactiveMcpKeymemo correctly finds the most recent key by comparing timestamps- The
McpEntrytype integrates cleanly with the existingRailEntrydiscriminated union - MCP icon uses proper gradient fills matching the brand
Good to ship.
Summary
sm_source: "mcp"orsm_kind: "mcp_oauth_exchange").