Fix YouTube URL host matching#1176
Open
anirudh5harma wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@MaheshtheDev Have a look pls |
![vorflux[bot]](https://avatars.githubusercontent.com/in/2483280?s=60&v=4){kind=small}
Contributor
|
Testing evidence from delegated testing subagent: Result: PASS — no functional bug found in the YouTube hostname-matching fix. Checks performed:
Evidence artifacts: Attached Images and Videos 🎥 View recording: pr1176-youtube-browser.webm |
anirudh5harma
force-pushed
the
codex/1175-youtube-url-substring-detection
branch
from
bddd23a to
213ada8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notyoutube.com,evil.example/youtube.com, andyoutube.com.evil.exampleyoutu.belinks, spoofed hosts, non-http protocols, and invalid video IDsCloses #1175
Tests
bun test apps/web/components/utils.test.tsbun test apps/web/components/*.test.ts apps/web/lib/*.test.tsbunx biome check apps/web/components/utils.ts apps/web/components/utils.test.ts apps/web/components/document-modal/content/index.tsx apps/web/components/document-modal/content/yt-video.tsx apps/web/components/document-icon.tsx apps/web/components/timeline-view.tsxNotes
bunx tsc --noEmitfromapps/webstill fails on existing unrelated app/package type errors, including missing workspace type resolution and pre-existing strictness errors outside this diff.Session Details
(aside)to your comment to have me ignore it.