feat: add grafana create, update and delete alert rules by WashingtonKK · Pull Request #3873 · superplanehq/superplane

WashingtonKK · 2026-03-31T19:25:50Z

Implements: #3850

This expands the Grafana Integration by adding three components:

grafana.CreateAlertRule
grafana.UpdateAlertRule
grafana.DeleteAlertRule
grafana.ListAlertRules
grafana.GetAlertRule

Demo Video

Screencast.from.2026-04-01.12-37-35.webm

Note

Medium Risk
Adds new Grafana Alerting Provisioning API write paths (create/update/delete) plus new resource listing logic and stricter webhook provisioning behavior, which could impact existing Grafana integrations if permissions or payload merging are incorrect.

Overview
Expands the Grafana integration to manage Grafana-managed alert rules via the Alerting Provisioning HTTP API, adding new workflow components to create, get, list, update (partial merge), and delete alert rules, along with example outputs and UI mappers for rendering metadata/execution details.

Introduces shared alert-rule spec decoding/sanitization/validation and payload building/merging (including contact point attach/clear semantics, provenance checks, deep-clone safety, and condition/query rebuild logic), and extends the Grafana client with alert-rule/folder endpoints plus a mutex to serialize notification policy tree updates.

Tightens Grafana webhook setup to fail fast instead of falling back to manual setup on client/provisioning failures, and updates Query Data Source configuration by renaming dataSourceUid to dataSource, removing the timezone field, and interpreting datetime-local inputs as UTC (with stricter timezone requirements added for annotation datetime-local parsing).

^{Reviewed by Cursor Bugbot for commit 87ffad3. Bugbot is set up for automated code reviews on this repo. Configure here.}

superplanehq-integration · 2026-03-31T19:25:54Z

👋 Commands for maintainers:

/sp start - Start an ephemeral machine (takes ~30s)
/sp stop - Stop a running machine (auto-executed on pr close)

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

WashingtonKK · 2026-04-03T07:55:44Z

Screencast.from.2026-04-03.10-48-59.webm

Screencast.from.2026-04-03.10-54-32.webm

- Added validation for `For`, `NoDataState`, and `ExecErrState` fields in `CreateAlertRuleSpec` and `UpdateAlertRuleSpec` to ensure they are not empty and conform to expected formats. - Introduced helper functions `isValidDuration`, `isValidNoDataState`, and `isValidExecErrState` to validate respective fields. - Added unit tests to cover new validation scenarios, ensuring robust error handling for invalid inputs. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

- Changed alert rule condition from "A" to "C" across multiple JSON files. - Introduced new query models for alert rules, including a "reduce" model and a "threshold" model, enhancing the alerting capabilities. - Updated the data structure to support additional references and expressions for improved alert evaluation. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

- Changed alert rule condition from "A" to "C" in multiple sections of the Grafana documentation. - Added new query models, including "reduce" and "threshold", to improve alert evaluation capabilities. - Updated data structures to support additional references and expressions for enhanced alerting functionality. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 87ffad3. Configure here.}

…#3873) Implements: superplanehq#3850 This expands the Grafana Integration by adding three components: - `grafana.CreateAlertRule` - `grafana.UpdateAlertRule` - `grafana.DeleteAlertRule` - `grafana.ListAlertRules` - `grafana.GetAlertRule` ### Demo Video [Screencast from 2026-04-01 12-37-35.webm](https://github.com/user-attachments/assets/831343d3-cf4d-4159-a49f-b82b81f438dc)  --- > [!NOTE] > **Medium Risk** > Adds new Grafana Alerting Provisioning API write paths (create/update/delete) plus new resource listing logic and stricter webhook provisioning behavior, which could impact existing Grafana integrations if permissions or payload merging are incorrect. > > **Overview** > Expands the Grafana integration to manage **Grafana-managed alert rules** via the Alerting Provisioning HTTP API, adding new workflow components to `create`, `get`, `list`, `update` (partial merge), and `delete` alert rules, along with example outputs and UI mappers for rendering metadata/execution details. > > Introduces shared alert-rule spec decoding/sanitization/validation and payload building/merging (including contact point attach/clear semantics, provenance checks, deep-clone safety, and condition/query rebuild logic), and extends the Grafana client with alert-rule/folder endpoints plus a mutex to serialize notification policy tree updates. > > Tightens Grafana webhook setup to **fail fast** instead of falling back to manual setup on client/provisioning failures, and updates `Query Data Source` configuration by renaming `dataSourceUid` to `dataSource`, removing the timezone field, and interpreting datetime-local inputs as UTC (with stricter timezone requirements added for annotation datetime-local parsing). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 87ffad3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  --------- Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

WashingtonKK mentioned this pull request Mar 31, 2026

feat: add grafana create, update anddelete alert rules #3860

Closed

WashingtonKK changed the title ~~feat: add grafana create, update anddelete alert rules~~ feat: add grafana create, update and delete alert rules Mar 31, 2026

cursor Bot reviewed Mar 31, 2026

View reviewed changes

WashingtonKK added 2 commits April 1, 2026 11:34

feat: add grafana create, update anddelete alert rules

89de57c

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

feat: add grafana alert rule list and delete actions

f3c0555

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

WashingtonKK force-pushed the feat/grafana-alert-rules branch from bc9e1fa to f3c0555 Compare April 1, 2026 08:40

superplane-policy-bot Bot requested review from forestileao, lucaspin and shiroyasha April 1, 2026 08:40

fix comments

8fed016

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 1, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

WashingtonKK added 3 commits April 1, 2026 12:17

fix ci

11ac3d5

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix comments

6408d8f

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

add rule name to getAlertRule node

88c3df2

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 1, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/grafana.go

WashingtonKK added 2 commits April 1, 2026 13:00

fix comment

610c918

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

update create alert rule

1120158

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

WashingtonKK added 2 commits April 2, 2026 14:36

fix bugbot comment

1006b07

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Merge branch 'main' into feat/grafana-alert-rules

46075dd

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

Comment thread pkg/integrations/grafana/alert_rule_common.go

WashingtonKK added 2 commits April 2, 2026 14:54

update list alert rules

d4eec2e

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix comments

c5feeeb

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go Outdated

fix comments

a5eedd9

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

fix bugbot comment

c772e7b

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/list_alert_rules.go

WashingtonKK added 4 commits April 2, 2026 16:06

fix lint

47a92a2

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Merge branch 'main' into feat/grafana-alert-rules

eff6641

Merge branch 'main' into feat/grafana-alert-rules

5de46e1

Merge branch 'main' into feat/grafana-alert-rules

c596e73

Merge branch 'main' into feat/grafana-alert-rules

e514c9f

cursor Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

cursor Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/example_output_create_alert_rule.json

WashingtonKK added 2 commits April 9, 2026 19:01

cursor Bot reviewed Apr 10, 2026

View reviewed changes

Comment thread web_src/src/pages/workflowv2/mappers/grafana/alert_rule_shared.ts

Comment thread pkg/integrations/grafana/client.go Outdated

AleksandarCole assigned forestileao Apr 10, 2026

AleksandarCole added the pr:stage-3/3 Ready for full, in-depth, review label Apr 10, 2026

forestileao reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

forestileao reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

forestileao reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/delete_alert_rule.go

forestileao reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/get_alert_rule.go

forestileao reviewed Apr 10, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/list_alert_rules.go

remove id prefix and add frontend tests

ea9e015

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

superplane-policy-bot Bot requested a review from forestileao April 13, 2026 08:15

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/list_alert_rules.go

WashingtonKK added 2 commits April 13, 2026 11:23

update component docs, update resource names

3461262

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Merge branch 'main' into feat/grafana-alert-rules

ab237de

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/alert_rule_common.go

fix bugbot comment

87ffad3

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread pkg/integrations/grafana/query_data_source.go

forestileao approved these changes Apr 13, 2026

View reviewed changes

forestileao merged commit 2c4a35b into superplanehq:main Apr 13, 2026
6 checks passed

Conversation

WashingtonKK commented Mar 31, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo Video

Uh oh!

superplanehq-integration Bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WashingtonKK commented Apr 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WashingtonKK commented Mar 31, 2026 •

edited by cursor Bot

Loading