fix: Sidebar: Combination of "TIP {{" + descriptions doesn't look good#3883
Closed
cursor[bot] wants to merge 1 commit intomainfrom
Closed
fix: Sidebar: Combination of "TIP {{" + descriptions doesn't look good#3883cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
When a field has both a quickTip (e.g. 'Tip: type {{ to start an expression.')
and a description, the absolutely-positioned tip text overlaps with the
description text rendered below the input, creating a cluttered appearance
in the sidebar.
Conditionally omit the quickTip prop when the field already has a description.
The expression hint is still discoverable through the autocomplete dropdown's
built-in fallback tip.
Fixes #2529
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
forestileao,
lucaspin and
shiroyasha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2529
When a configuration field has both a
quickTip(e.g. "Tip: type{{to start an expression.") and adescription, the absolutely-positioned tip text fromAutoCompleteInputoverlaps with the description text rendered below the input byConfigurationFieldRenderer, creating a cluttered and hard-to-read layout in the sidebar.Changes
Conditionally omit the
quickTipprop when the field already has adescriptionin the following field renderers:StringFieldRenderer—quickTipfor{{expression hintAnyPredicateListFieldRenderer—quickTipfor{{expression hintIntegrationResourceFieldRenderer—quickTipfor{{expression hintExpressionFieldRenderer—quickTipfor$payload browsing hintWhen a field has a description, the description is shown instead. The expression/payload hints remain discoverable through the autocomplete dropdown's built-in fallback tip (which renders when the user starts typing
{{or$). When a field has no description, the quickTip is still shown as before.