add optional inclusion of the config file for analysis

[svelle]

No description provided.

[Copilot]

Pull Request Overview

This pull request adds an optional configuration file inclusion for AI analysis of support packets.

• Introduces a global variable and helper function to manage the sanitized configuration content.
• Extracts and reads sanitized_config.json when the include-config flag is enabled.
• Updates the CLI flags and integrates configuration content into analysis prompts.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
parser_support_packet.go	Adds global variable, helper to clear config content, and extraction logic.
main.go	Introduces the include-config flag and ensures previous config is cleared.
analyzer_llm.go	Appends configuration information into both the system and user prompts for analysis.

[Copilot]

Pull Request Overview

This PR adds support for optionally including the Mattermost configuration file (sanitized_config.json) in AI-driven log analysis.

• Introduces SupportPacketResult to return both parsed logs and configuration content.
• Extends parseSupportPacket to extract and load the config file when the --include-config flag is set.
• Propagates configContent through processLogs, analyzeWithLLM, and all provider-specific functions; updates CLI flags, shell completions, and documentation.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
parser_support_packet.go	Changed parseSupportPacket signature to return *SupportPacketResult, added extraction and loading of sanitized_config.json.
main.go	Added includeConfig flag, updated calls to processLogs to pass configContent, and updated flag registration/completion.
analyzer_llm.go	Extended analyzeWithLLM, prepareAnalysisPrompts, and provider wrappers to accept and incorporate configContent.
README.md	Documented the --include-config flag, updated examples and descriptions.

Comments suppressed due to low confidence (3)

parser_support_packet.go:9

• The import block currently only includes "strings", but this file uses zip.OpenReader, fmt.Errorf, os.MkdirTemp, filepath.Join, and logger.*. Add missing imports for "archive/zip", "fmt", "os", "path/filepath", and the logger package.

import (

main.go:301

• [nitpick] Consider adding unit tests for the --include-config flag and SupportPacketResult logic to verify that sanitized_config.json is correctly extracted, loaded into ConfigContent, and passed through to the AI analysis pipeline.

cmd.Flags().BoolVar(&includeConfig, "include-config", false, "Include configuration in AI analysis (support-packet only)")

parser_support_packet.go:41

• Variables aiAnalyze and includeConfig are referenced here but not passed into parseSupportPacket. Either inject these flags as parameters or ensure they are available as package-level variables to avoid undefined identifier errors.

if aiAnalyze && includeConfig {

[Copilot]

Pull Request Overview

This PR adds optional inclusion of the Mattermost configuration file (sanitized_config.json) in AI analysis of support packets.

• parseSupportPacket now returns both logs and configuration content via SupportPacketResult
• CLI updates: added --include-config flag and extended processLogs to forward config to LLM calls
• Analyzer enhancements: all LLM provider functions and prompt preparation now include config data when present
• Documentation updated to cover the new flag and behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
parser_support_packet.go	Return *SupportPacketResult, extract and include sanitized_config.json when requested
main.go	Added includeConfig flag, updated processLogs signature and support-packet command
analyzer_llm.go	Extended analyzeWithLLM and provider methods to accept and incorporate configContent
README.md	Documented --include-config flag and updated support-packet usage examples

Comments suppressed due to low confidence (1)

parser_support_packet.go:18

• Update this comment to mention that the function now returns *SupportPacketResult and optionally includes the sanitized configuration content.

// parseSupportPacket extracts and parses logs from a Mattermost support packet zip file

[Copilot]

[nitpick] The code iterates over reader.File twice (once for config and once for log files). Consider merging these passes into a single loop to reduce redundant iteration and simplify control flow.

Suggested change

	// Extract sanitized_config.json if needed for AI analysis
	var configPath string
	if aiAnalyze && includeConfig {
	for _, file := range reader.File {
	if strings.HasSuffix(file.Name, "sanitized_config.json") {
	configPath = filepath.Join(tempDir, "sanitized_config.json")
	if err := extractZipFile(file, configPath); err != nil {
	logger.Warn("Failed to extract sanitized_config.json from support packet", "file", file.Name, "error", err)
	configPath = "" // Reset if extraction failed
	} else {
	logger.Debug("Extracted sanitized_config.json for AI analysis", "path", configPath)
	}
	break
	}
	}
	}
	// Look for log files in the zip
	for _, file := range reader.File {
	// Process files in the zip
	var configPath string
	for _, file := range reader.File {
	// Check if it's the sanitized_config.json file
	if aiAnalyze && includeConfig && strings.HasSuffix(file.Name, "sanitized_config.json") {
	configPath = filepath.Join(tempDir, "sanitized_config.json")
	if err := extractZipFile(file, configPath); err != nil {
	logger.Warn("Failed to extract sanitized_config.json from support packet", "file", file.Name, "error", err)
	configPath = "" // Reset if extraction failed
	} else {
	logger.Debug("Extracted sanitized_config.json for AI analysis", "path", configPath)
	}
	continue
	}

[Copilot]

[nitpick] To simplify function signatures and reduce duplication, consider adding ConfigContent as a field on LLMConfig instead of passing it as a separate parameter through all analyzeWith* functions.

Suggested change

	func analyzeWithLLM(logs []LogEntry, config LLMConfig, configContent string) error {
	func analyzeWithLLM(logs []LogEntry, config LLMConfig) error {

[hanzei]

@svelle Is this ready for review?

[svelle]

@svelle Is this ready for review?

Yes indeed

[hanzei]

Neat idea 👍

[hanzei]

Can we do this in memory instead of writing the file to disk? Seems like a potential security issue.

[hanzei]

Should we return the content instead of a path? That makes it easier to the caller.