chore: remove {@const ...} tags from template#1110
Conversation
🦋 Changeset detectedLatest commit: 09f2a4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Conduitry
left a comment
There was a problem hiding this comment.
One issue is that we need to bump the devdep version of Svelte that's used in tests. And then also probably ESLint and Prettier plugins.
But also, if we're introducing new Svelte features into the demo apps, we should bump the ranges of the compiler, ESLint, and Prettier plugins that are set in package.json in the various templates.
|
@jycouet are the test failures expected? |
Looking at it now its because of minimum age of packages. We should probably stick to defaults of 1440 https://pnpm.io/fr/settings#minimumreleaseage ? Today we have https://github.com/sveltejs/cli/blob/main/pnpm-workspace.yaml#L1 (2 days) Should be soon green. (svelte |
7e79907 to
c849991
Compare
Replaces
{@const ...}with declaration tags. Tests fail locally for me, not clear why, hoping they pass in CI