Skip to content

feat(eslint): support loading config from vite.config.* #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuel3108 wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −5
Open

feat(eslint): support loading config from vite.config.* #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
440bcf9
feat(eslint): support loading config from `vite.config.*`
manuel3108 Jun 5, 2026
a9e54ec
changeset
manuel3108 Jun 5, 2026
68dd930
Merge branch 'main' into feat/use-sveltejs-load-config-eslint
manuel3108 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plenty-trees-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

feat(eslint): support loading config from `vite.config.*`
13 changes: 10 additions & 3 deletions packages/sv/src/addons/eslint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default defineAddon({
sv.devDependency('eslint-plugin-svelte', '^3.19.0');
sv.devDependency('globals', '^17.4.0');
sv.devDependency('@eslint/js', '^10.0.1');
sv.devDependency('@sveltejs/load-config', '^0.1.1');
sv.devDependency('@types/node', getNodeTypesVersion());

if (typescript) sv.devDependency('typescript-eslint', '^8.58.1');
Expand All @@ -33,7 +34,13 @@ export default defineAddon({
'eslint.config.js',
transforms.script(({ ast, comments, js }) => {
const eslintConfigs: Array<AstTypes.Expression | AstTypes.SpreadElement> = [];
js.imports.addDefault(ast, { from: './svelte.config.js', as: 'svelteConfig' });

js.imports.addNamed(ast, { from: '@sveltejs/load-config', imports: ['loadConfig'] });
const svelteConfigStatement = js.common.parseStatement(
"\nconst svelteConfig = await loadConfig('./', { traverse: false })"
);
js.common.appendStatement(ast, { statement: svelteConfigStatement });

const gitIgnorePathStatement = js.common.parseStatement(
"\nconst gitignorePath = path.resolve(import.meta.dirname, '.gitignore');"
);
Expand Down Expand Up @@ -90,7 +97,7 @@ export default defineAddon({
projectService: true,
extraFileExtensions: ['.svelte'],
parser: js.variables.createIdentifier('ts.parser'),
svelteConfig: js.variables.createIdentifier('svelteConfig')
svelteConfig: js.variables.createIdentifier('svelteConfig.config')
}
}
});
Expand All @@ -100,7 +107,7 @@ export default defineAddon({
files: ['**/*.svelte', '**/*.svelte.js'],
languageOptions: {
parserOptions: {
svelteConfig: js.variables.createIdentifier('svelteConfig')
svelteConfig: js.variables.createIdentifier('svelteConfig.config')
}
}
});
Expand Down
5 changes: 3 additions & 2 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import svelte from 'eslint-plugin-svelte';
import { defineConfig, includeIgnoreFile } from 'eslint/config';
import globals from 'globals';
import ts from 'typescript-eslint';
import svelteConfig from './svelte.config.js';
import { loadConfig } from '@sveltejs/load-config';

const svelteConfig = await loadConfig('./', { traverse: false });
const gitignorePath = path.resolve(import.meta.dirname, '.gitignore');

export default defineConfig(
Expand All @@ -31,7 +32,7 @@ export default defineConfig(
projectService: true,
extraFileExtensions: ['.svelte'],
parser: ts.parser,
svelteConfig
svelteConfig: svelteConfig.config
}
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"@playwright/test": "^1.60.0",
"@sveltejs/adapter-node": "^5.5.4",
"@sveltejs/kit": "^2.57.0",
"@sveltejs/load-config": "^0.1.1",
"@sveltejs/vite-plugin-svelte": "^7.0.0",
"@tailwindcss/forms": "^0.5.11",
"@tailwindcss/typography": "^0.5.19",
Expand Down
Loading