fix: ignore EEXIST errors when symlinking traced files in adapter-vercel - #16809
Open
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Open
fix: ignore EEXIST errors when symlinking traced files in adapter-vercel#16809elliott-with-the-longest-name-on-github wants to merge 1 commit into
EEXIST errors when symlinking traced files in adapter-vercel#16809elliott-with-the-longest-name-on-github wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/e1fc35517f43ebdc6576c5fa59b6361b1b025d59Open in |
🦋 Changeset detectedLatest commit: e1fc355 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16806
In a pnpm workspace,
@vercel/nftcan trace the same dependency through two different symlink chains (e.g.apps/app/node_modules/Xandpackages/ui/node_modules/X) that both realpath to the same file in the pnpm store.create_function_bundleassumed traced file → destination is 1:1, so the second occurrence hitfs.symlinkSyncon adestthat already existed and crashed the build withEEXIST.Wraps the symlink in a try/catch that ignores
EEXIST— both chains would produce an equivalent link, so skipping the duplicate is safe.