tests: fix test flakiness by avoiding localhost and adding port retry#557
Open
tbutter wants to merge 1 commit into
Open
tests: fix test flakiness by avoiding localhost and adding port retry#557tbutter wants to merge 1 commit into
tbutter wants to merge 1 commit into
Conversation
Owner
|
Hey, thanks. I think a better way would be to adapt what we do over in buildbtw. That way, we can ensure a process will definitely get the port that it's locking because we can pass the lock around. |
Owner
|
Also I'd appreciate it if you could separate out the DNS stuff to a second commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flakiness came up during nix package upgrade NixOS/nixpkgs#513622 (comment)
AI disclosure: Used antigravity cli to find the flaky test and create a patch.
be unreliable or resolve to the IPv6 loopback address ( ::1 ) first. Because dummyhttp binds to 0.0.0.0 (IPv4-only by default), connecting via IPv6 fails or times out.
number, and cause dummyhttp to fail to bind on startup. Additionally, the startup loop would wait for the full timeout (1 second) instead of immediately failing-fast if the child process exited early.