feat: add ability to configure swap quote v3 endpoints#1580
Closed
feat: add ability to configure swap quote v3 endpoints#1580
Conversation
Drakeoon
changed the base branch from
chore/keystore-signing-api-provided-tx
to
develop
Drakeoon
changed the title
Drakeoon
changed the title
Drakeoon
requested review from
ice-chillios and
towanTG
and removed request for
towanTG
towanTG
reviewed
Nov 12, 2025
| @@ -106,12 +106,10 @@ export function SwapKit< | |||
|
|
|||
| if (plugin) { | |||
| if (type === ApproveMode.CheckOnly && "isAssetValueApproved" in plugin) { | |||
Collaborator
There was a problem hiding this comment.
might want to use match here to reduce if structures
ice-chillios
force-pushed
the
develop
branch
2 times, most recently
from
6735d9c to
94e558a
Compare
Contributor
Author
|
Closing this PR, I'll split this it into smaller ones:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done:
/quoteand/swapendpoints, allow overriding their API keyImportant
This branch was originally created from #1532, but it looks like the commits are made on a fresh branch that was synced with develop. Need to ensure we're using the right SDK approach for checking /swap and /quote endpoints