skip big rows#1
Open
swapna267 wants to merge 3 commits into
Open
Conversation
ghost
reviewed
May 22, 2018
| import java.util.List; | ||
| import java.util.Random; | ||
|
|
||
| public class TestSkipBigRowScanner { |
There was a problem hiding this comment.
need to add a category for this test:
@category(MediumTests.class)
ghost
reviewed
May 25, 2018
| // Ok, we are good, let's try to get some results from the main heap. | ||
| populateResult(results, this.storeHeap, scannerContext, current); | ||
| try { | ||
| LOG.info("scanner context progress before:"+scannerContext.getKeepProgress()); |
There was a problem hiding this comment.
Is this logging just the skipped row? shouldn't there be a more explicit log stating Table and row specific details of the row that was too large?
Owner
Author
There was a problem hiding this comment.
oops no just added while debugging something. Will remove.
Removed the logging on printing Rowkey for big rows. Is INFO logging ok for that . Might get huge in some cases.
ddlatham
reviewed
May 29, 2018
| if (doSkipBigRows) { | ||
| LOG.info("Skipping big row during scan.Table:" + htableDescriptor.getTableName() + | ||
| " ,rowKey:" + Bytes.toStringBinary(current.getRowArray(), | ||
| current.getRowOffset(), current.getRowLength())); |
There was a problem hiding this comment.
I'm thinking this should be DEBUG level
ddlatham
reviewed
May 29, 2018
| populateResult(results, this.storeHeap, scannerContext, current); | ||
| } catch(RowTooBigException e) { | ||
| if (doSkipBigRows) { | ||
| LOG.info("Skipping big row during scan.Table:" + htableDescriptor.getTableName() + |
ghost
reviewed
May 29, 2018
| @@ -0,0 +1,168 @@ | |||
| package org.apache.hadoop.hbase.regionserver; | |||
ddlatham
reviewed
May 29, 2018
| throw e; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
seems a lot of repetition. can we factor it out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.