Add reference doc for databricks.py, avatar.py and simba_utils.py#7
Open
banana-bison wants to merge 2 commits into
Open
Add reference doc for databricks.py, avatar.py and simba_utils.py#7banana-bison wants to merge 2 commits into
banana-bison wants to merge 2 commits into
Conversation
Signed-off-by: banana-bison <bananabison@gmail.com>
TomeHirata
reviewed
Apr 9, 2026
| ): | ||
| """ | ||
| Args: | ||
| model: Name of the model as stored in the databricks store |
Collaborator
There was a problem hiding this comment.
what is databricks store?
Author
There was a problem hiding this comment.
My understanding is that databricks provides a store for ML models and dspy client for databricks provides functions to manage/use them through dspy's paradigm. The store is question is the databricks feature store https://docs.databricks.com/aws/en/machine-learning/feature-store/. Is my understanding correct?
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
| @@ -32,6 +34,21 @@ def prepare_models_for_resampling(program: dspy.Module, n: int, teacher_settings | |||
| return models | |||
|
|
|||
| def wrap_program(program: dspy.Module, metric: Callable): | |||
Collaborator
There was a problem hiding this comment.
can we also add type hint?
Author
There was a problem hiding this comment.
this function (wrap_program), already has type hints. Did you mean the function below it: wrapped_program?
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
TomeHirata
reviewed
Apr 9, 2026
Signed-off-by: banana-bison <bananabison@gmail.com>
Author
|
@TomeHirata I've address all the review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3