fix: drop the dead font-awesome CodePen stylesheet - #275
Merged
Conversation
#271 changed the customHtml example's buttons from fa-thumbs-up / fa-thumbs-down to emoji, but left codepenCssExternal pointing at font-awesome, so "Edit in CodePen" still injected a stylesheet nothing used. The other two codepenCssExternal values stay: animate.css is still needed by the customAnimation example's pen, and bootstrap4-buttons.css by the bootstrap example's. No font-awesome reference remains in the JS bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #271.
That PR changed the
customHtmlexample's buttons fromfa-thumbs-up/fa-thumbs-downto emoji, but leftcodepenCssExternalon the matching<CodeExample>pointing at font-awesome. So "Edit in CodePen" still injected a stylesheet the pen no longer used.The other two
codepenCssExternalvalues stay, since their pens genuinely need them:animate.cssfor thecustomAnimationexample (bundling it in #270 covers this site, not an exported pen) andbootstrap4-buttons.cssfor the bootstrap example.Verified: 0 font-awesome references remain in the JS bundle; both other external stylesheets are still emitted.
bun run lintandbun run buildpass.🤖 Generated with Claude Code