Change effective precision of [DateUtils toJulian] from float to double#1
Open
drewolbrich wants to merge 1 commit intoswerdlow:masterfrom
drewolbrich:master
Open
Change effective precision of [DateUtils toJulian] from float to double#1drewolbrich wants to merge 1 commit intoswerdlow:masterfrom drewolbrich:master
drewolbrich wants to merge 1 commit intoswerdlow:masterfrom
drewolbrich:master
Conversation
[NSDate timeIntervalSince1970] returns a double, and [DateUtils toJulian] was casting it a float, stripping off valuable precision. This was causing [SunCalc getSunPositionDate:latitude:longitude:] to return a Sun position that would stay fixed for many seconds at a time, and then suddenly jump half a degree when it eventually changed. In test code, the Sun altitude remained unchanged at 8.76209 degrees for many seconds, and then later changed to 9.29653, where it stayed for an extended period. This behavior occurred only on the device, and not in the simulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NSDate timeIntervalSince1970] returns a double, and [DateUtils
toJulian] was casting it a float, stripping off valuable
precision. This was causing [SunCalc
getSunPositionDate:latitude:longitude:] to return a Sun position that
would stay fixed for many seconds at a time, and then suddenly jump
half a degree when it eventually changed.
In test code, the Sun altitude remained unchanged at 8.76209 degrees
for many seconds, and then later changed to 9.29653, where it stayed
for an extended period.
This behavior occurred only on the device, and not in the simulator.