Skip to content

port to gtk3#22

Open
v1cont wants to merge 8 commits intoswesterfeld:masterfrom
v1cont:master
Open

port to gtk3#22
v1cont wants to merge 8 commits intoswesterfeld:masterfrom
v1cont:master

Conversation

@v1cont
Copy link
Copy Markdown

@v1cont v1cont commented Oct 17, 2019

i propose a series of patches for porting gst123 to gtk3. in additional to port code itself, there is a desktop file for opening files with gst123 in a xdg manner, and fix for working without control terminal

@swesterfeld
Copy link
Copy Markdown
Owner

Ok, I've merged most of your code into master. I didn't merge:

  • code intended to make gst123 usable without controlling tty (or via .desktop file) - the reason is that in case of audio files, gst123 will not open a window, so the user will not have any option to stop playback - gst123 is intended as a command line player, if you want a full blown UI player, there are probably better solutions
  • the possibility to increase volume to over 100% - this has always been supported, so I don't understand the point of your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants