Add workaround for gzipped gpg keys to fix random CI failures#680
Open
fwcd wants to merge 5 commits intoswift-actions:mainfrom
Open
Add workaround for gzipped gpg keys to fix random CI failures#680fwcd wants to merge 5 commits intoswift-actions:mainfrom
fwcd wants to merge 5 commits intoswift-actions:mainfrom
Conversation
fwcd
added a commit
to fwcd/swiftplot
that referenced
this pull request
Sep 3, 2024
ma2bd
added a commit
to zefchain/serde-reflection
that referenced
this pull request
Dec 18, 2024
## Summary Use patched swift action as #55 was not enough sadly. See also swift-actions/setup-swift#680 ## Test Plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines the fixes by @pfusik and @redsun82, updating the gpg URL from https://swift.org to the canonical location under https://www.swift.org and unzipping the fetched keys to work around #591. This logic is scoped to macOS and Linux for now, since these Unix commands may be unavailable on Windows.
While this is not the most elegant solution, having it upstream would fix the majority of random CI failures for Swift packages for now without vendoring a custom version of this action, until the likely server-sided misconfiguration is fixed.