Skip to content

Add AndroidConfigurationTests#16

Merged
colemancda merged 7 commits into
mainfrom
feature/configuration
Mar 22, 2026
Merged

Add AndroidConfigurationTests#16
colemancda merged 7 commits into
mainfrom
feature/configuration

Conversation

@colemancda
Copy link
Copy Markdown
Collaborator

@colemancda colemancda commented Mar 22, 2026

Test run started. Testing Library Version: 6.3 Target Platform: aarch64-unknown-linux-android
[▸] Suite AndroidChoreographerTests started.
[▸] Suite AndroidNativeTests started.
[▸] Suite AndroidLooperTests started.
[▸] Suite AndroidContextTests started.
[▸] Suite AndroidLoggingTests started.
[▸] Suite AndroidConfigurationTests started.
[▸] Suite AndroidFileManagerTests started.
[▸] Suite AndroidSystemTests started.
[▸] Test testChoreographer() started.
[▸] Test testEmbedInCodeResource() started.
[-] Test testMainActor() skipped: "temporarily disabled on Android due to hang"
[▸] Test testProperties() started.
[▸] Test testDiff() started.
[▸] Test testAndroidContext() started.
[-] Test testNetwork() skipped: "temporarily disabled on Android due to hang"
[▸] Test testOSLogAPI() started.
[▸] Test testMatches() started.
[▸] Test testAssetManager() started.
[▸] Test testSystem() started.
[▸] Test testLooper() started.
[✓] Test testAssetManager() passed after 0.006 seconds.
[✓] Test testDiff() passed after 0.005 seconds.
[✓] Test testProperties() passed after 0.007 seconds.
[✓] Test testMatches() passed after 0.007 seconds.
[✓] Test testChoreographer() passed after 0.005 seconds.
[✓] Test testLooper() passed after 0.004 seconds.
[✓] Test testEmbedInCodeResource() passed after 0.004 seconds.
[✓] Test testOSLogAPI() passed after 0.007 seconds.
[✓] Test testSystem() passed after 0.006 seconds.
[✓] Suite AndroidFileManagerTests passed after 0.015 seconds.
[✓] Suite AndroidNativeTests passed after 0.016 seconds.
[✓] Suite AndroidSystemTests passed after 0.016 seconds.
[✓] Suite AndroidLooperTests passed after 0.017 seconds.
[✓] Suite AndroidChoreographerTests passed after 0.016 seconds.
[✓] Suite AndroidConfigurationTests passed after 0.017 seconds.
[✓] Suite AndroidLoggingTests passed after 0.017 seconds.
[✓] Test testAndroidContext() passed after 0.018 seconds.
[✓] Suite AndroidContextTests passed after 0.024 seconds.
[✓] Test run with 12 tests in 8 suites passed after 0.030 seconds.
executing command: /Users/coleman/Library/Android/sdk/platform-tools/adb uninstall org.swift.test.swift_android_native
Success
[✓] Uninstalling test APK (0.23s)

@colemancda colemancda requested a review from marcprux March 22, 2026 14:09
Copy link
Copy Markdown

@marcprux marcprux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple questions.

Comment thread Sources/AndroidFileManager/Configuration.swift
Comment thread Sources/AndroidFileManager/Configuration.swift
Comment thread Package.swift
.testTarget(
name: "AndroidConfigurationTests",
dependencies: [
"AndroidFileManager"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why you changed "AndroidAssetManager" to "AndroidFileManager"? I think either is fine, but assets and files aren't really the same thing…

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the reason was to make it encompass the AssetManager, StorageManager (ObbFiles) and the Configuration which for some reason is tied to AssetManager. I felt AndroidFileManager was generic enough for those 3 types. We could break it into 3 targets but they all seem related to file management.

@colemancda colemancda merged commit 6f57b2e into main Mar 22, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants