Add AndroidConfigurationTests#16
Merged
Merged
Conversation
marcprux
approved these changes
Mar 22, 2026
marcprux
left a comment
There was a problem hiding this comment.
Looks great! Just a couple questions.
| .testTarget( | ||
| name: "AndroidConfigurationTests", | ||
| dependencies: [ | ||
| "AndroidFileManager" |
There was a problem hiding this comment.
Curious why you changed "AndroidAssetManager" to "AndroidFileManager"? I think either is fine, but assets and files aren't really the same thing…
Collaborator
Author
There was a problem hiding this comment.
Well, the reason was to make it encompass the AssetManager, StorageManager (ObbFiles) and the Configuration which for some reason is tied to AssetManager. I felt AndroidFileManager was generic enough for those 3 types. We could break it into 3 targets but they all seem related to file management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.