Set url.full attribute on spans logged for HTTP requests#906
Conversation
|
Added the more scoped logging and configuration options to opt into full URL logging and to opt out to path logging. I chose to mark |
|
I think Almost any string field can, in theory, have PII, and I think this is the wrong place to try to make that call. Let application owners filter PII in their telemetry backends instead. |
Are you suggesting that we don’t have any configuration options for this in async-http-client? I personally don’t have an opinion either way. |
|
That's right. That's both how OpenTelemetry and the Swift observability libraries are designed. |
We previously only set the request method on these spans, which made it hard to identify which exact HTTP request was causing this span to be emitted. Also record the URL of the HTTP request to add more information to these spans. While at it, also record the request body size because we already had an attribute key configured for it.
|
Updated the PR to remove the configuration options. |
We previously only set the request method on these spans, which made it hard to identify which exact HTTP request was causing this span to be emitted.
Also record the URL of the HTTP request to add more information to these spans. While at it, also record the request body size because we already had an attribute key configured for it.