Add swift version files as exclusions to the license header checks#124
Merged
shahmishal merged 3 commits intoMay 14, 2025
Merged
Conversation
FranzBusch
reviewed
May 14, 2025
| exclude_list=":(exclude).license_header_template" | ||
| fi | ||
|
|
||
| exclude_list="${exclude_list}:(exclude).swift-version" # Swift version files will never have license headers in them |
Member
There was a problem hiding this comment.
I think we should move line 43 outside of the if and append to that static_excloude_list variable
Member
Author
|
The windows nightly failure seems transient since the change here is in bash script and the other windows jobs pass with other toolchains. |
FranzBusch
approved these changes
May 14, 2025
shahmishal
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift version files are designed to be very simple one-line files with the
intended version of swift to be used for a repo or directory. This helps to
support ad-hoc scripting use-cases where the file can be read as a script
variable without any extra parsing so that the correct toolchain can be
used based on directory name, etc. These files won't have license headers
in them so there's no need for the license check to check for that.
Add
.swift-versionto the exclusion list automatically so that reposdon't need to add them manually to the
.licenseignorefile on their own.