Enable the api breaking check to work for private repos#143
Merged
Conversation
# Motivation Currently, the API breaking check is not working for private repos since it requires git credentials to be configured so that it can clone the repo again # Modifications This sets the `persist-credentials` to `true` for only the diagnose API breaking checks job since that one has a credible need to re-use the git credentials # Result API breaking change checking now works for private repos
al45tair
approved these changes
Jul 31, 2025
ahoppen
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# Motivation
Currently, the API breaking check is not working for private repos since it requires git credentials to be configured so that it can clone the repo again
Modifications
This sets the
persist-credentialstotruefor only the diagnose API breaking checks job since that one has a credible need to re-use the git credentialsResult
API breaking change checking now works for private repos