Windows: add Dockerfile to smoke test arbitrary installers#505
Windows: add Dockerfile to smoke test arbitrary installers#505shahmishal merged 4 commits intoswiftlang:mainfrom
Conversation
|
@speednoisemovement Can you also create a match Dockerfile for 2019? |
Done. IIUC 1809 is the same ltsc2019 and it's what's used elsewhere in this repo, please LMK if that's wrong. |
|
Could we enable long paths so we don't run into any issues with the OS file system And also could we install python for lldb |
I would really prefer that we do not do this. This is going to hide issues with long paths that users might run into. We cannot assume that the user can set this (corporate environments do often block the ability to set arbitrary HKLM nodes).
We should be able to do this at least. |
|
For 2022 we should use Python 3.9.13 For 1809 we should use Python 3.7.8 That way the lldb testing uses the same python that built the installer |
Will do, but can you point me to where those versions are coming from? |
|
They are from our CI machines which will build the installer in our CI jobs, someone at desk could use an arbitrary python but since these dockerfiles are for CI we should likely match the builders |
justice-adams-apple
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Split off from swiftlang/swift#84770
This adds a Dockerfile which installs a given Swift installer and sets the given script to the entry point.