Skip to content

Windows: add Dockerfile to smoke test arbitrary installers#505

Merged
shahmishal merged 4 commits intoswiftlang:mainfrom
speednoisemovement:win_smoke_tests
Feb 13, 2026
Merged

Windows: add Dockerfile to smoke test arbitrary installers#505
shahmishal merged 4 commits intoswiftlang:mainfrom
speednoisemovement:win_smoke_tests

Conversation

@speednoisemovement
Copy link
Copy Markdown
Contributor

Split off from swiftlang/swift#84770

This adds a Dockerfile which installs a given Swift installer and sets the given script to the entry point.

@shahmishal
Copy link
Copy Markdown
Member

@speednoisemovement Can you also create a match Dockerfile for 2019?

@speednoisemovement
Copy link
Copy Markdown
Contributor Author

@speednoisemovement Can you also create a match Dockerfile for 2019?

Done. IIUC 1809 is the same ltsc2019 and it's what's used elsewhere in this repo, please LMK if that's wrong.

@justice-adams-apple
Copy link
Copy Markdown
Contributor

@speednoisemovement

Could we enable long paths so we don't run into any issues with the OS file system

reg add "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem" 
  /v "LongPathsEnabled" /d "1"

And also could we install python for lldb

@compnerd
Copy link
Copy Markdown
Member

@speednoisemovement

Could we enable long paths so we don't run into any issues with the OS file system

reg add "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem" 
  /v "LongPathsEnabled" /d "1"

I would really prefer that we do not do this. This is going to hide issues with long paths that users might run into. We cannot assume that the user can set this (corporate environments do often block the ability to set arbitrary HKLM nodes).

And also could we install python for lldb

We should be able to do this at least.

@justice-adams-apple
Copy link
Copy Markdown
Contributor

For 2022 we should use Python 3.9.13

For 1809 we should use Python 3.7.8

That way the lldb testing uses the same python that built the installer

@speednoisemovement
Copy link
Copy Markdown
Contributor Author

For 2022 we should use Python 3.9.13

For 1809 we should use Python 3.7.8

That way the lldb testing uses the same python that built the installer

Will do, but can you point me to where those versions are coming from?

@justice-adams-apple
Copy link
Copy Markdown
Contributor

They are from our CI machines which will build the installer in our CI jobs, someone at desk could use an arbitrary python but since these dockerfiles are for CI we should likely match the builders

Copy link
Copy Markdown
Contributor

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shahmishal shahmishal merged commit 0676cbb into swiftlang:main Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants