[Driver] Inject per-instance stdout/stderr streams#2137
Open
cachemeifyoucan wants to merge 1 commit into
Open
Conversation
Driver and ToolExecutionDelegate now take a ThreadSafeOutputByteStream for stdout and stderr (defaulting to the TSCBasic globals). TestDriver defaults to per-instance in-memory buffers, so parallel tests no longer race by reassigning TSCBasic.stderrStream / stdoutStream while printOutputFileMap and the parseable-output tests run. rdar://177157368
cachemeifyoucan
requested review from
DougGregor,
artemcm,
compnerd and
owenv
as code owners
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver and ToolExecutionDelegate now take a ThreadSafeOutputByteStream for stdout and stderr (defaulting to the TSCBasic globals). TestDriver defaults to per-instance in-memory buffers, so parallel tests no longer race by reassigning TSCBasic.stderrStream / stdoutStream while printOutputFileMap and the parseable-output tests run.
rdar://177157368