Update for swift-syntax AttributeSyntax.Arguments changes#971
Conversation
Some specialized `AttributeSyntax.Arguments` cases and related types are being removed from swift-syntax.
|
Is that the only place in TokenStreamCreator that's actually affected? I thought we covered more of the attributes you mentioned. Maybe it's not as big a savings as I thought it would be. 🙁 (We should still do it though.) We have a little bit of a chicken-and-egg problem here since the tests will fail unless this is built against a version of swift-syntax that has the parser changes to produce argument lists instead of the old nodes. Do we support paired repos in the new PR testing workflow? |
|
Ah no |
As far as I tested locally 🙂 Many are underscored attributes, no wonder they weren't handled. |
|
Let me try and push for a review on swiftlang/github-workflows#52 and allow cross-PR testing for GitHub actions. In the meantime, we’ll have to find someone with force merge capabilities to merge this. |
|
Merging despite failures as we have no way to run cross-PR testing here yet. |
Some specialized
AttributeSyntax.Argumentscases and related types are being removed from swift-syntax.