Local/global reference management functions#11
Merged
Conversation
madsodgaard
approved these changes
Mar 16, 2026
madsodgaard
left a comment
madsodgaard
left a comment
There was a problem hiding this comment.
I think this is a great addition.
Only thing I think we should do, is make sure we clear the OOM exception that PushLocalFrame might throw, and throw a Swift error instead.
The alternative is moving this to SwiftJava and using the translatingJNIExceptions helper.
Collaborator
Author
|
Added the OOM clearing, good call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion about having helpers for frame management.
We probably should not "wrap" all interface APIs... however when there si a chance to make usage safer like here about what if the push failed by making a with... method I think it is probably worth it.
Open to opinions though cc @marcprux @madsodgaard
Context is swiftlang/swift-java#616