Support for nested arrays in Array JavaValue#17
Merged
Conversation
The types and lookups for jniNewArray did not properly handle nested arrays; this corrects that and by handling the special naming expectations this method has: [[[[[[Ljava/lang/String; for nested arrays, however skipping the L if just looking for plain class name
Collaborator
Author
|
Ugh, I forgot primitives |
Collaborator
Author
|
windows and nightly android/main have infra issues. |
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Apr 7, 2026
This implements support of nested arrays of primitives or objects and relies on updated jni-core in swiftlang/swift-java-jni-core#17
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Apr 7, 2026
This implements support of nested arrays of primitives or objects and relies on updated jni-core in swiftlang/swift-java-jni-core#17
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Apr 7, 2026
This implements support of nested arrays of primitives or objects and relies on updated jni-core in swiftlang/swift-java-jni-core#17
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Apr 8, 2026
This implements support of nested arrays of primitives or objects and relies on updated jni-core in swiftlang/swift-java-jni-core#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types and lookups for jniNewArray did not properly handle nested arrays; this corrects that and by handling the special naming expectations this method has: [[[[[[Ljava/lang/String; for nested arrays, however skipping the L if just looking for plain class name