Skip to content

Prefer unsafeBitcast on arrays, the as! is costly #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktoso merged 1 commit into from
Apr 22, 2026
Merged

Prefer unsafeBitcast on arrays, the as! is costly #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftJavaJNICore/BridgedValues/JavaValue+Array.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ extension Array: JavaValue where Element: JavaValue {
}
initializedCount = count
}
self = result as! Self
self = unsafeBitCast(result, to: Self.self)
} else if Element.self == Int8.self {
let result = [Int8](unsafeUninitializedCapacity: Int(jniCount)) { buffer, initializedCount in
Int8.jniGetArrayRegion(in: environment)(
Expand All @@ -57,7 +57,7 @@ extension Array: JavaValue where Element: JavaValue {
)
initializedCount = count
}
self = result as! Self
self = unsafeBitCast(result, to: Self.self)
} else {
// Slow path for other types: create intermediate array and map
let jniArray = [Element.JNIType](unsafeUninitializedCapacity: count) { buffer, initializedCount in
Expand Down
Loading