[jextract] Prepare all inputs before analyze()#222
Merged
Conversation
Register all the files to `Swift2JavaTranslator` (and `NominalTypeResolution`) and `analye()` all the files at once. `Swift2JavaVisitor.visit(_: ExtentionDeclSyntax)` requires all the nominal types are prepared in the `nominalResolution`. Otherwise it's just ignored. Also previously, writing files happend for each file iteration but actually, it is not a per-source file operation. Instead, it only writes the current state of the translator.
DougGregor
approved these changes
Apr 15, 2025
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
Ah, thank you! Might this fix #209?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register all the files to
Swift2JavaTranslator(andNominalTypeResolution) andanalye()all the files at once.Swift2JavaVisitor.visit(_: ExtentionDeclSyntax)requires all the nominal types are prepared in thenominalResolution. Otherwise it's just ignored.Also previously, writing files was performed for each file iteration but actually, it is not a per-source file operation. Instead, it only writes the current state of the translator, so multiple calls were redundant.