jextract/wrap-java(!): add filter-include/exclude same as wrap-java has#655
Merged
Conversation
This breaks wrap-java properties in swift-java.config which are now javaFilterInclude/Exlcude! We will change the settings format once again... a full redesign is in place here.
ktoso
force-pushed
the
wip-jextract-filters
branch
from
4cc3405 to
d71c2e5
Compare
ktoso
force-pushed
the
wip-jextract-filters
branch
from
e28bd4d to
25bf9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds filtering capabilities similar to what wrapJava had before to jextract. This matters for large projects where we don't want to expose "everything" to Java.
This breaks wrap-java properties in swift-java.config which are now javaFilterInclude/Exclude -- the keys have changed.
We also handle the expected outputs as otherwise swiftpm would blow up.
We will have to change the settings format once again I expect... so will try to do it all at once in a tagged release.
This change was AI assisted. I've specifically chosen the way we hook this into the commands, the duplication is intentional. We cannot just share the one setting across all commands because they work slightly differently and should have docs specific to the command they're in.