jextract: Fix compilation errors in constrained generic extensions#734
Merged
Conversation
# Conflicts: # Tests/JExtractSwiftTests/JNI/JNIGenericTypeTests.swift
ktoso
reviewed
May 12, 2026
ktoso
approved these changes
May 12, 2026
ktoso
reviewed
May 12, 2026
| } | ||
| return true | ||
| return false | ||
| } |
Collaborator
There was a problem hiding this comment.
Hmmm this seems suspicious, one sec
Collaborator
There was a problem hiding this comment.
Yeah this is wrong because we must match all same type requirements, I'll push a fix.
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
May 12, 2026
All same type constraints must match, not just one of them. This is a follow up after swiftlang#734 (comment) swiftlang#734
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
May 12, 2026
All same type constraints must match, not just one of them. This is a follow up after swiftlang#734 (comment) swiftlang#734
ktoso
added a commit
that referenced
this pull request
May 12, 2026
All same type constraints must match, not just one of them. This is a follow up after #734 (comment) #734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses compilation errors occurring in the generated "opener" code for certain constrained generic extensions.
When an extension has a protocol requirement, the functions were being exported into "opener" code that does not satisfy the protocol constraint, leading to a build failure.
In cases like
where Bait == Element, the generator was incorrectly exporting functions.Similar to the protocol case, the opener fails to satisfy the same-type requirement when a type parameter is involved on the right-hand side.
I have updated the
Swift2JavaVisitorimplementation to correctly identify these problematic constraints.