jextract/jni: Fix compilation of nested generic types#738
Merged
Conversation
ktoso
reviewed
May 12, 2026
ktoso
approved these changes
May 12, 2026
…stedTypes.swift Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, nested generic types cause compilation errors because the generator fails to include necessary namespaces and generic parameters.
Based on my experiments, Swift handles type inference differently for nested generics compared to top-level generics.
While top-level generic parameters can often be inferred within an extension, nested generic types require explicit type parameters when referenced inside the extension body.
To resolve this, I have updated the generator to:
The root cause was that
SwiftTypeinSwiftFunctionSignaturewas missing its generic parameters.It appears that
ImportedNominalType.swiftTypewas incorrectly stripping these parameters during the type conversion process.This PR fixes that logic to ensure generic information is preserved.