[test][android] Temporarily disable new Reflection/availability_custom_domains.swift test#88795
Merged
Merged
Conversation
Member
finagolfin
commented
May 3, 2026
finagolfin
commented
- Explanation: IRGen: Skip emitting reflection metadata for enum elements that don't exist at runtime #88764 just introduced this test, which fails on the Android CI, likely related to linker issues we've seen with the older lld in NDK 28, [test][android] Fix one test and disable others for NDK 28 and API 24 #88056, so I'll check this locally with the upcoming NDK 30 beta and re-enable with those other Reflection tests once we update the CI to the next NDK 30 beta in the coming month.
- Scope: just one test
- Issues: none
- Risk: zero
- Testing: none
…m_domains.swift test Likely related to lld linker issues we've seen with other Reflection tests with NDK 28, will probably work with the upcoming NDK 30.
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci test android |
DougGregor
approved these changes
May 4, 2026
Member
Author
|
Checked this test locally with NDK 30 beta 1 and it works fine with that newer lld, so I will enable it again once we update the Android CI to use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.