Remove the reload extension dialog#2196
Open
matthewbastien wants to merge 9 commits into
Open
Conversation
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
added
full-test-run
matthewbastien
force-pushed
the
no-reloading
branch
4 times, most recently
from
39b6526 to
f4c95fc
Compare
matthewbastien
force-pushed
the
no-reloading
branch
3 times, most recently
from
c17a38b to
e680379
Compare
matthewbastien
force-pushed
the
no-reloading
branch
from
e680379 to
c1fba62
Compare
matthewbastien
force-pushed
the
no-reloading
branch
from
c1fba62 to
b5fa3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of forcing the user to reload the extension when toolchain changes are detected, the Swift extension will now automatically reload the
FolderContextorWorkspaceContextin these cases. The extension can detect changes to:swiftly use -g..swift-versionfiles./var/select/developer_dir.Each of these will only force a reload if the active toolchain is managed by either
swiftlyorxcrun.I've added an
onDidChangeWorkspaceContextevent to theSwiftExtensionApithat can be used to detect when theWorkspaceContexthas been reloaded. For updates to theFolderContexttoolchain I reused theFolderOperation.swiftVersionUpdatedevent that we added a while back, but didn't do anything with.This PR builds on top of the work in #1932.
Tasks