Feat: add custom entity fiter to Trace#203
Closed
chenbuyi2019 wants to merge 1 commit intoswiftly-solution:betafrom
Closed
Feat: add custom entity fiter to Trace#203chenbuyi2019 wants to merge 1 commit intoswiftly-solution:betafrom
chenbuyi2019 wants to merge 1 commit intoswiftly-solution:betafrom
Conversation
skuzzis
approved these changes
Jan 6, 2026
Member
|
The pull request isn't merged yet as we're rethinking some design choices for the Trace API |
e32c3cc to
24b9cc3
Compare
Member
|
This PR will be addresses in #289 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add custom entity fiter to Trace.
So we could easily bypass the entity by its class\team or even color.
And new simple trace line functions.
Too many params won't make it simple.
I dont think trace should be called from another thread.
So I just put
CustomFilterFuncin static and set it to null after the trace finished.It means the current custom filter of the current running trace.
Examples:
Type of Change
Please delete options that are not relevant.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Changes Made
Detailed Changes
New functions add to
ITraceManager.Testing
Test Environment
Test Cases
Describe the test cases you've run:
Breaking Changes
List any breaking changes and migration steps:
Performance Impact
Details:
Checklist
Screenshots/Videos (if applicable)
Add screenshots or videos demonstrating the changes:
Additional Notes
Any additional information, context, or notes for reviewers:
For Maintainers