Release PR - #746
Merged
Merged
Conversation
try to improve memory leak in route
…aultHookManager-in-services
… on more old data
…es-from-DefaultHookManager-in-services Allow to set withMaxQueueEntries from DefaultHookManager in services
…-can-decode-lagacy-mode-base64 allow to decode base64 legacy format
Try to approach `shutdown(req, SHUT_WR)` better with `HttpConnection.shutdown()`. As `HttpConnection.close()` causes undesired race-conditions in some edge-cases. Namely an upstream server sending a `Connection: close` header with a response where the response body is split over several tcp fragments. This occasionly CAN cause that the upstream response gets cut in half in between some fragments due to the close cut off the incoming stream too early. Which then when combinded with a `Content-Length` response, will cause our downstream client to hang as he never will receive enough bytes in the response.
That timeout is neither an idle, nor a connect timeout. So (ab)using `Role.getTimeout()` doesn't sound like an ideal choice. But I'll stick with it, as it got requested that way in #744 (comment)
MSOP-6438: Handle edge-case in ConnClose responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.