fix(frontend): remove duplicate exported AggregatedSession type alias#159
Closed
OnlyTerp wants to merge 1 commit into
Closed
fix(frontend): remove duplicate exported AggregatedSession type alias#159OnlyTerp wants to merge 1 commit into
OnlyTerp wants to merge 1 commit into
Conversation
The route-local AggregatedSession type was exported alongside the canonical client contract in frontend/src/features/agent/session-contracts.ts, causing npm run check:contracts to fail on duplicate declarations. Keep the canonical export in session-contracts.ts and make the route-local type non-exported. No runtime or response shape change.
Contributor
Author
|
Closing — main applied the exact fix (the route-local type is no longer exported) and |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158
Removes the
exportkeyword from the route-localAggregatedSessiontype alias infrontend/src/app/api/agent/sessions/all/route.ts. The canonical client contract remains exported fromfrontend/src/features/agent/session-contracts.ts.Verification
npm run check:contracts✅npm --prefix frontend run typecheck✅npm --prefix frontend run lint✅Notes