Refactor CLI structure and improve PDF merge/split robustness with metadata preservation and safer object handling#1
Open
PhotoDotPi wants to merge 2 commits into
Open
Conversation
Refactor collect_pdfs_recursive to track visited directories and handle errors more robustly. Update PDF metadata handling and improve page tree creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the CLI structure and makes the merge/split logic more robust.
Main changes:
infosubcommand instead of relying on implicit behavior.Info,ID,Encrypt) when merging and splitting.Overall this makes merging and splitting more reliable, especially for larger or more complex PDFs.