Skip to content

[Security] Update security.rst#15963

Closed
BahmanMehrdad wants to merge 1 commit intosymfony:5.3from
BahmanMehrdad:5.3
Closed

[Security] Update security.rst#15963
BahmanMehrdad wants to merge 1 commit intosymfony:5.3from
BahmanMehrdad:5.3

Conversation

@BahmanMehrdad
Copy link
Copy Markdown
Contributor

All deleted and added texts are displayed in the main text of the site.

All deleted and added texts are displayed in the main text of the site.
Copy link
Copy Markdown
Contributor Author

@BahmanMehrdad BahmanMehrdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review

@javiereguiluz
Copy link
Copy Markdown
Member

@BahmanMD thanks for this fix. Technically speaking you are right. The problem is that the real bug is different.

This code block is a "diff" and it should look similar to this example:

diff-highlight

The code block has "added lines" and "removed lines". If highlight worked as expected, you'd see the added lines green and the removed lines red. But, there is a bug with the highlighting of these code blocks and that's why you see those duplicated contents.

This bug has been reported in symfony-tools/docs-builder#124 and we hope to fix it soon.
Meanwhile, I must close your pull request without merging ... but thanks for your help anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants