Add battery pack integration for skill matching#235
Open
nikomatsakis wants to merge 5 commits into
Open
Conversation
jlizen
approved these changes
May 31, 2026
Member
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
Looks good overall, I haven't tested it end to end, I assume you have.
nikomatsakis
force-pushed
the
batttery-pack-integration
branch
from
54033e5 to
becbb18
Compare
Battery packs are crate bundles managed by `cargo bp` rather than declared as normal Cargo dependencies. Plugins can now reference them in predicates (e.g. `crates = ["cli-battery-pack"]`) and symposium will discover installed packs by acquiring the `cargo-bp` binary into its cache and running `cargo bp status --json`. The discovery is gracefully skipped when `cargo-bp` is unavailable, so projects without battery packs see no change in behavior. Co-authored-by: Claude <claude@anthropic.com>
- Use `normalize_crate_name` when deduplicating battery packs against workspace crates (hyphen/underscore insensitivity) - Destructure `AcquiredSource` after await instead of `.map()` on Result - Wrap `StatusCommand::run()` in `spawn_blocking` to avoid blocking the async runtime - Add integration test for graceful degradation when cargo-bp is unavailable Co-authored-by: Claude <claude@anthropic.com>
nikomatsakis
force-pushed
the
batttery-pack-integration
branch
from
7e414fd to
22baa0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Battery packs are crate bundles managed by
cargo bprather than declared as normal Cargo dependencies. Plugins can now reference them in predicates (e.g.crates = ["cli-battery-pack"]) and symposium will discover installed packs by acquiring thecargo-bpbinary into its cache and runningcargo bp status --json.The discovery is gracefully skipped when
cargo-bpis unavailable, so projects without battery packs see no change in behavior.Disclosure questions
AI disclosure.
Questions for reviewers.