fix: pass --repo to gh release create in release workflow - #16
Merged
Conversation
The github-release job downloads artifacts only and has no git checkout, so gh fails inferring the repository. Explicit --repo and --verify-tag fix the v0.9.0 release step failure. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repo "${{ github.repository }}"sogh release createworks without a git checkout in thegithub-releasejob--verify-tagsince the tag is already pushed by thereleasejobFixes the v0.9.0 workflow failure where publish/docs succeeded but GitHub release failed with
fatal: not a git repository.Test plan
publish_onlyafter a successful bump)Made with Cursor