fix(cmake): find_dependency for STLSoft/b64 in pantheios-config - #36
Open
synesissoftware wants to merge 2 commits into
Open
fix(cmake): find_dependency for STLSoft/b64 in pantheios-config#36synesissoftware wants to merge 2 commits into
synesissoftware wants to merge 2 commits into
Conversation
Exported Pantheios.core records $<LINK_ONLY:b64::core> (and STLSoft) when built with b64; without find_dependency(), consumers saw a missing b64::core imported target. Wire find_dependency into pantheios-config, link b64 with a plain if(b64_FOUND) so the export is clean, and update install-smoke to rely on that (install b64 in CI; find_package(pantheios) only).
mwsis
approved these changes
Aug 8, 2026
Hazzoz
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported Pantheios.core records
$<LINK_ONLY:b64::core>(andSTLSoft) when built with b64; withoutfind_dependency(), consumers saw a missingb64::coreimported target. Wirefind_dependency()into pantheios-config, link b64 with a plainif(b64_FOUND)so the export is clean, and update install-smoke to rely on that (install b64 in CI; find_package(pantheios) only).