CMake/CI: optional ACE discovery and dedicated ACE cell - #5
Merged
Conversation
…y string no longer over-reads the source buffer (MinGW unit-test segfault in **test.unit.stlsoft.string.simple_string**)
Use lexicographic boilerplate/dev/idiomatic/master/rc1–rc3 triggers; drop rc4/rc5/update. Keep unfiltered pull_request.
Canonical short name for helper-script status/--help messages, loaded via tr -d whitespace per Synesis convention.
Detect MSYSTEM to enable MinGW configure/make by default, and add a ProjectName-aware CTest wrapper aligned with peer libs.
Enable install-path normalisation on CMake 3.31+, and correct CMAKE_BUILD_TYPE CACHE assignment / .git detection in BuildType.cmake.
Mark completed README/CI/.sis/CMake modernisation items, consolidate duplicate blog/Doxygen bullets, and clarify GHA vs dialect-matrix coverage.
Narrow post-artifact +x restore under examples/, and harden run_all_examples.sh to skip CMake files (e.g. CTestTestfile.cmake) so example jobs do not try to execute them.
mwsis
approved these changes
Aug 7, 2026
Replace ACE_OS::snprintf in the ACE_Time_Value string-access helpers with stlsoft_C_snprintf, and route stream_insert through the same invoke_ACE_OS_snprintf overloads (TODO 1.11.1).
Imported deps (xTests) were supplying includes as -isystem; Apple Clang searches /usr/local/include first, so an older install shadowed local _STLSOFT_VER_* macros (e.g. test.unit.versions / RC5).
… MinGW `-Werror=maybe-uninitialized`
mwsis
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lean FindACE, NO_ACE/--no-ace, and a linux-gcc cell-ace job (libace-dev) so ACESTL can be exercised without burdening the default matrix; keep ace on push.branches for this branch.