Skip to content

test: add probeNode devtools command - #1001

Merged
piotr-iohk merged 1 commit into
masterfrom
feat/lsp-node-probe-targets
Jun 9, 2026
Merged

test: add probeNode devtools command#1001
piotr-iohk merged 1 commit into
masterfrom
feat/lsp-node-probe-targets

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Closes #1000

This PR adds a probeNode devtools command for mainnet keysend probe targets used by nightly Lightning monitoring.

Description

  • Adds ProbeNode to the debug devtools ContentProvider, mirroring the existing invoice probe flow
  • Accepts nodeId, amountSats/amountMsat, targetName, and timeoutSeconds over adb
  • Delegates to LightningRepo.sendProbeForNode() and returns the same success/failure JSON shape as probeInvoice

Pairs with:

Preview

QA Notes

Manual Tests

  • 1. Build mainnet debug E2E APK → install on emulator/device with probe wallet.
  • 2. With node running, adb shell content call to probeNode with a known pubkey and 1000 sats → JSON success response.
  • 3. regression: adb shell content call to probeInvoice with a test BOLT11 → still returns expected success/failure JSON.

Automated Checks

  • just compile passed locally.
  • Existing LightningRepoTest.sendProbeForNode covers repo delegation; no new unit tests for devtools (same precedent as probeInvoice).
  • CI: standard compile, unit test, and detekt checks run by the PR bot.

Made with Cursor

@piotr-iohk piotr-iohk self-assigned this Jun 9, 2026
@piotr-iohk
piotr-iohk requested review from ovitrif and pwltr June 9, 2026 12:44

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
utAck

@piotr-iohk
piotr-iohk merged commit 1fe7f46 into master Jun 9, 2026
17 checks passed
@piotr-iohk
piotr-iohk deleted the feat/lsp-node-probe-targets branch June 9, 2026 15:22
pwltr pushed a commit that referenced this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add probeNode devtools for keysend probes

3 participants