fix: remove app from recents on close - #822
Merged
Merged
Conversation
ovitrif
marked this pull request as draft
March 4, 2026 18:08
ovitrif
force-pushed
the
fix/remove-app-from-recents
branch
from
March 4, 2026 20:29
d63eaf1 to
9d36acd
Compare
ovitrif
marked this pull request as ready for review
March 4, 2026 20:29
ovitrif
requested review from
ben-kaufman,
jvsena42 and
piotr-iohk
and removed request for
ben-kaufman and
piotr-iohk
March 4, 2026 22:20
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovitrif
force-pushed
the
fix/remove-app-from-recents
branch
from
March 4, 2026 22:32
b2de56b to
cada0f9
Compare
ovitrif
enabled auto-merge
March 4, 2026 23:27
This was referenced Mar 4, 2026
jvsena42
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the "Close App" button in the foreground service notification so it actually removes the app from the Android recents drawer.
The previous approach used
App.currentActivity?.value?.finishAffinity()which had two problems: the activity reference is always null when the app is backgrounded (making it a no-op), andfinishAffinity()doesn't remove from recents anyway.The fix uses
ActivityManager.appTasksto finish and remove all app tasks directly from the service context, after gracefully stopping the LDK node first.Also fixes the Claude Code Review workflow never posting comments — adds missing
--commentflag and--allowedToolsforghCLI (reviews were silently discarded since inception). We can only verifyclaude[bot]posts review comments on the next PR opened (after merge).Preview
before.mp4
after.mp4
QA Notes