fix: use actual probe result - #920
Merged
Merged
Conversation
ovitrif
marked this pull request as draft
April 29, 2026 15:17
This comment was marked as resolved.
This comment was marked as resolved.
ovitrif
force-pushed
the
fix/probe-actual-result
branch
from
April 29, 2026 15:36
2f0f118 to
d35fb70
Compare
ovitrif
marked this pull request as ready for review
April 29, 2026 15:51
This comment has been minimized.
This comment has been minimized.
ovitrif
force-pushed
the
fix/probe-actual-result
branch
from
April 29, 2026 19:09
d35fb70 to
337aecd
Compare
ovitrif
enabled auto-merge
April 29, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #918
Ports:
Description
Before this change, the Probing Tool reported success once a probe was sent. Now it uses the returned
paymentIds, waits for matchingProbeSuccessful/ProbeFailedevents, and shows the actual result.Also adds node ID / keysend probes and bumps
ldk-node-androidfor the required probe handle support.Differs from iOS PR by supporting LNURL inputs for probing — manually verified with success using WoS.
Preview
N/A
QA Notes
Tests
Prereq: Build & run flavor
mainnetDebug, use a wallet with 1 LN channel in ready state.1. Probe Success
2. Probe Failure
3. Node ID Keysend
5. LNURL Probe
Optionally, track filtered logs: