fix: lightning activities not displayed on spending wallet #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #411 The lightning activities were being assigned to a local variable instead of the @published class property, causing them not to display on the spending wallet screen.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
Author
|
@piotr-iohk might be a good idea to add an e2e test for the activities list in savings and spending screens |
piotr-iohk
approved these changes
Jan 27, 2026
Collaborator
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
Tested, LGTM.
e2e tests updated to check activities displayed in spending balance screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Description
This PR fixes a bug where lightning activities were not displayed on the spending wallet screen, even though they appeared in "show all".
The issue was a variable shadowing bug:
let lightningActivities = ...created a local variable that shadowed the@Publishedclass property, so the fetched activities were never assigned to the published property and the UI showed "No activity yet".Linked Issues/Tasks
Screenshot / Video
N/A - bug fix